Commit da994db9 authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Bjorn Andersson
Browse files

remoteproc: sysmon: Correct subsys_name_len type in QMI request 



The QMI message encoder has up until recently read a single byte (as
elem_size == 1), but with the introduction of big endian support it's
become apparent that this field is expected to be a full u32 -
regardless of the size of the length in the encoded message (which is
what elem_size specifies).

The result is that the encoder now reads past the length byte and
rejects the unreasonably large length formed when including the
following 3 bytes from the subsys_name array.

Fix this by changing to the expected type.

Fixes: 1fb82ee8 ("remoteproc: qcom: Introduce sysmon")
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Reviewed-by: default avatarChris Lew <christopher.lew@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260220-qmi-encode-invalid-length-v2-1-5674be35ab29@oss.qualcomm.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent f9b88859

drivers/remoteproc/qcom_sysmon.c

+1 −1
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ static const struct qmi_elem_info ssctl_shutdown_resp_ei[] = { 
};



struct ssctl_subsys_event_req {

	u8 subsys_name_len;

	u32 subsys_name_len;

	char subsys_name[SSCTL_SUBSYS_NAME_LENGTH];

	u32 event;

	u8 evt_driven_valid;