Commit daac51c7 authored by Stefan Metzmacher's avatar Stefan Metzmacher Committed by Steve French
Browse files

smb: client: fix smbdirect_recv_io leak in smbd_negotiate() error path 



During tests of another unrelated patch I was able to trigger this
error: Objects remaining on __kmem_cache_shutdown()

Cc: Steve French <smfrench@gmail.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Long Li <longli@microsoft.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org
Fixes: f198186a ("CIFS: SMBD: Establish SMB Direct connection")
Signed-off-by: default avatarStefan Metzmacher <metze@samba.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 251090e2

fs/smb/client/smbdirect.c

+3 −1
Original line number Diff line number Diff line
@@ -1108,8 +1108,10 @@ static int smbd_negotiate(struct smbd_connection *info) 
	log_rdma_event(INFO, "smbd_post_recv rc=%d iov.addr=0x%llx iov.length=%u iov.lkey=0x%x\n",

		       rc, response->sge.addr,

		       response->sge.length, response->sge.lkey);

	if (rc)

	if (rc) {

		put_receive_buffer(info, response);

		return rc;

	}



	init_completion(&info->negotiate_completion);

	info->negotiate_done = false;