Commit dac64cb3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Deucher
Browse files

drm/amdgpu: Fix amdgpu_ip_block_hw_fini() 



This NULL check is reversed so the function doesn't work.

Fixes: dad01f93 ("drm/amdgpu: validate hw_fini before function call")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/f4fc849e-4e76-4448-8657-caa4c69910b0@stanley.mountain


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 4c5d0fc5

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+1 −1
Original line number Diff line number Diff line
@@ -3308,7 +3308,7 @@ static void amdgpu_ip_block_hw_fini(struct amdgpu_ip_block *ip_block) 
{

	int r;



	if (ip_block->version->funcs->hw_fini) {

	if (!ip_block->version->funcs->hw_fini) {

		DRM_ERROR("hw_fini of IP block <%s> not defined\n",

			  ip_block->version->funcs->name);

	} else {