Unverified Commit dacafdcc authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/tests: modeset: Fix drm_display_mode memory leak 



drm_mode_find_dmt() returns a drm_display_mode that needs to be
destroyed later one. The drm_test_pick_cmdline_res_1920_1080_60() test
never does however, which leads to a memory leak.

Let's make sure it's freed.

Reported-by: default avatarPhilipp Stanner <phasta@mailbox.org>
Closes: https://lore.kernel.org/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.camel@mailbox.org/


Fixes: 8fc0380f ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()")
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250408-drm-kunit-drm-display-mode-memleak-v1-2-996305a2e75a@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 13c1d5f3

drivers/gpu/drm/tests/drm_client_modeset_test.c

+3 −0
Original line number Diff line number Diff line
@@ -95,6 +95,9 @@ static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test) 
	expected_mode = drm_mode_find_dmt(priv->drm, 1920, 1080, 60, false);

	KUNIT_ASSERT_NOT_NULL(test, expected_mode);



	ret = drm_kunit_add_mode_destroy_action(test, expected_mode);

	KUNIT_ASSERT_EQ(test, ret, 0);



	KUNIT_ASSERT_TRUE(test,

			  drm_mode_parse_command_line_for_connector(cmdline,

								    connector,