Commit dad32805 authored by Qianfeng Rong's avatar Qianfeng Rong Committed by Jakub Kicinski
Browse files

ppp: use vmalloc_array() to simplify code 



Remove array_size() calls and replace vmalloc() with vmalloc_array() in
bsd_alloc().

vmalloc_array() is also optimized better, resulting in less instructions
being used.

Signed-off-by: default avatarQianfeng Rong <rongqianfeng@vivo.com>
Link: https://patch.msgid.link/20250816090659.117699-4-rongqianfeng@vivo.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fce21458

drivers/net/ppp/bsd_comp.c

+2 −2
Original line number Diff line number Diff line
@@ -406,7 +406,7 @@ static void *bsd_alloc (unsigned char *options, int opt_len, int decomp) 
 * Allocate space for the dictionary. This may be more than one page in

 * length.

 */

    db->dict = vmalloc(array_size(hsize, sizeof(struct bsd_dict)));

    db->dict = vmalloc_array(hsize, sizeof(struct bsd_dict));

    if (!db->dict)

      {

	bsd_free (db);
@@ -425,7 +425,7 @@ static void *bsd_alloc (unsigned char *options, int opt_len, int decomp) 
 */

    else

      {

        db->lens = vmalloc(array_size(sizeof(db->lens[0]), (maxmaxcode + 1)));

        db->lens = vmalloc_array(maxmaxcode + 1, sizeof(db->lens[0]));

	if (!db->lens)

	  {

	    bsd_free (db);