Commit db0d2d75 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Fix pipeDMC and ATS fault handling 



The fault handler is supposed to return true when it
handles the fault. The pipeDMC and ATS handlers are
returning false instead which results in the
"unreported faults" WARN triggering when it shouldn't.

Fixes: f13011a7 ("drm/i915: Pimp display fault reporting")
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250224173017.29500-1-ville.syrjala@linux.intel.com


Reviewed-by: default avatarVinod Govindapillai <vinod.govindapillai@intel.com>
parent ad45492c

drivers/gpu/drm/i915/display/intel_display_irq.c

+3 −3
Original line number Diff line number Diff line
@@ -1101,7 +1101,7 @@ static bool handle_plane_ats_fault(struct intel_crtc *crtc, enum plane_id plane_ 
			    "[CRTC:%d:%s] PLANE ATS fault\n",

			    crtc->base.base.id, crtc->base.name);



	return false;

	return true;

}



static bool handle_pipedmc_ats_fault(struct intel_crtc *crtc, enum plane_id plane_id)
@@ -1112,7 +1112,7 @@ static bool handle_pipedmc_ats_fault(struct intel_crtc *crtc, enum plane_id plan 
			    "[CRTC:%d:%s] PIPEDMC ATS fault\n",

			    crtc->base.base.id, crtc->base.name);



	return false;

	return true;

}



static bool handle_pipedmc_fault(struct intel_crtc *crtc, enum plane_id plane_id)
@@ -1123,7 +1123,7 @@ static bool handle_pipedmc_fault(struct intel_crtc *crtc, enum plane_id plane_id 
			    "[CRTC:%d:%s] PIPEDMC fault\n",

			    crtc->base.base.id, crtc->base.name);



	return false;

	return true;

}



static const struct pipe_fault_handler mtl_pipe_fault_handlers[] = {