Commit db73835f authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

net: phy: remove genphy_config_eee_advert 



bcm_config_lre_aneg() doesn't use genphy_config_eee_advert() any longer.
As this was the only user, we can remove genphy_config_eee_advert() now.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/37da7f3e-b883-4c07-9881-b8c0516822b7@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3cc97d2f

drivers/net/phy/phy_device.c

+0 −23
Original line number Diff line number Diff line
@@ -2239,29 +2239,6 @@ static int genphy_c37_config_advert(struct phy_device *phydev) 
				  adv);

}



/**

 * genphy_config_eee_advert - disable unwanted eee mode advertisement

 * @phydev: target phy_device struct

 *

 * Description: Writes MDIO_AN_EEE_ADV after disabling unsupported energy

 *   efficent ethernet modes. Returns 0 if the PHY's advertisement hasn't

 *   changed, and 1 if it has changed.

 */

int genphy_config_eee_advert(struct phy_device *phydev)

{

	int err;



	/* Nothing to disable */

	if (!phydev->eee_broken_modes)

		return 0;



	err = phy_modify_mmd_changed(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV,

				     phydev->eee_broken_modes, 0);

	/* If the call failed, we assume that EEE is not supported */

	return err < 0 ? 0 : err;

}

EXPORT_SYMBOL(genphy_config_eee_advert);



/**

 * genphy_setup_forced - configures/forces speed/duplex from @phydev

 * @phydev: target phy_device struct

include/linux/phy.h

+0 −1
Original line number Diff line number Diff line
@@ -1885,7 +1885,6 @@ int genphy_read_abilities(struct phy_device *phydev); 
int genphy_setup_forced(struct phy_device *phydev);

int genphy_restart_aneg(struct phy_device *phydev);

int genphy_check_and_restart_aneg(struct phy_device *phydev, bool restart);

int genphy_config_eee_advert(struct phy_device *phydev);

int __genphy_config_aneg(struct phy_device *phydev, bool changed);

int genphy_aneg_done(struct phy_device *phydev);

int genphy_update_link(struct phy_device *phydev);