Unverified Commit db81f6fa authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Mark Brown
Browse files

ASoC: codecs: zl38060: use new GPIO line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250408-gpiochip-set-rv-sound-v1-11-dd54b6ca1ef9@linaro.org


Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 127c53d6

sound/soc/codecs/zl38060.c

+8 −4
Original line number Diff line number Diff line
@@ -387,12 +387,12 @@ static const struct snd_soc_component_driver zl38_component_dev = { 
	.endianness		= 1,

};



static void chip_gpio_set(struct gpio_chip *c, unsigned int offset, int val)

static int chip_gpio_set(struct gpio_chip *c, unsigned int offset, int val)

{

	struct regmap *regmap = gpiochip_get_data(c);

	unsigned int mask = BIT(offset);



	regmap_update_bits(regmap, REG_GPIO_DAT, mask, val ? mask : 0);

	return regmap_update_bits(regmap, REG_GPIO_DAT, mask, val ? mask : 0);

}



static int chip_gpio_get(struct gpio_chip *c, unsigned int offset)
@@ -422,8 +422,12 @@ chip_direction_output(struct gpio_chip *c, unsigned int offset, int val) 
{

	struct regmap *regmap = gpiochip_get_data(c);

	unsigned int mask = BIT(offset);

	int ret;



	ret = chip_gpio_set(c, offset, val);

	if (ret)

		return ret;



	chip_gpio_set(c, offset, val);

	return regmap_update_bits(regmap, REG_GPIO_DIR, mask, mask);

}
@@ -436,7 +440,7 @@ static const struct gpio_chip template_chip = { 
	.direction_input = chip_direction_input,

	.direction_output = chip_direction_output,

	.get = chip_gpio_get,

	.set = chip_gpio_set,

	.set_rv = chip_gpio_set,



	.can_sleep = true,

};