Commit dba90f5a authored by Miquel Raynal's avatar Miquel Raynal
Browse files

mtd: spinand: winbond: Prevent unsupported frequencies on dual/quad I/O variants 



Dual and quad capable chips natively support dual and quad I/O variants
at up to 104MHz (1-2-2 and 1-4-4 operations). Reaching the maximum speed
of 166MHz is theoretically possible (while still unsupported in the
field) by adding a few more dummy cycles. Let's be accurate and clearly
state this limit.

Setting a maximum frequency implies adding the frequency parameter to
the macro, which is done using a variadic argument to avoid impacting
all the other drivers which already make use of this macro.

Fixes: 1ea808b4 ("mtd: spinand: winbond: Update the *JW chip definitions")
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 29384bbb

drivers/mtd/nand/spi/winbond.c

+2 −2
Original line number Diff line number Diff line
@@ -42,11 +42,11 @@ static SPINAND_OP_VARIANTS(update_cache_octal_variants, 
static SPINAND_OP_VARIANTS(read_cache_dual_quad_dtr_variants,

		SPINAND_PAGE_READ_FROM_CACHE_1S_4D_4D_OP(0, 8, NULL, 0, 80 * HZ_PER_MHZ),

		SPINAND_PAGE_READ_FROM_CACHE_1S_1D_4D_OP(0, 2, NULL, 0, 80 * HZ_PER_MHZ),

		SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 2, NULL, 0),

		SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 2, NULL, 0, 104 * HZ_PER_MHZ),

		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0),

		SPINAND_PAGE_READ_FROM_CACHE_1S_2D_2D_OP(0, 4, NULL, 0, 80 * HZ_PER_MHZ),

		SPINAND_PAGE_READ_FROM_CACHE_1S_1D_2D_OP(0, 2, NULL, 0, 80 * HZ_PER_MHZ),

		SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0),

		SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 104 * HZ_PER_MHZ),

		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0),

		SPINAND_PAGE_READ_FROM_CACHE_1S_1D_1D_OP(0, 2, NULL, 0, 80 * HZ_PER_MHZ),

		SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0),

include/linux/mtd/spinand.h

+6 −4
Original line number Diff line number Diff line
@@ -113,11 +113,12 @@ 
		   SPI_MEM_DTR_OP_DATA_IN(len, buf, 2),			\

		   SPI_MEM_OP_MAX_FREQ(freq))



#define SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(addr, ndummy, buf, len) \

#define SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(addr, ndummy, buf, len, ...) \

	SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1),				\

		   SPI_MEM_OP_ADDR(2, addr, 2),				\

		   SPI_MEM_OP_DUMMY(ndummy, 2),				\

		   SPI_MEM_OP_DATA_IN(len, buf, 2))

		   SPI_MEM_OP_DATA_IN(len, buf, 2),			\

		   SPI_MEM_OP_MAX_FREQ(__VA_ARGS__ + 0))



#define SPINAND_PAGE_READ_FROM_CACHE_3A_1S_2S_2S_OP(addr, ndummy, buf, len) \

	SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1),				\
@@ -151,11 +152,12 @@ 
		   SPI_MEM_DTR_OP_DATA_IN(len, buf, 4),			\

		   SPI_MEM_OP_MAX_FREQ(freq))



#define SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(addr, ndummy, buf, len) \

#define SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(addr, ndummy, buf, len, ...) \

	SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1),				\

		   SPI_MEM_OP_ADDR(2, addr, 4),				\

		   SPI_MEM_OP_DUMMY(ndummy, 4),				\

		   SPI_MEM_OP_DATA_IN(len, buf, 4))

		   SPI_MEM_OP_DATA_IN(len, buf, 4),			\

		   SPI_MEM_OP_MAX_FREQ(__VA_ARGS__ + 0))



#define SPINAND_PAGE_READ_FROM_CACHE_3A_1S_4S_4S_OP(addr, ndummy, buf, len) \

	SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1),				\