Commit dbcd754b authored by Philipp Stanner's avatar Philipp Stanner
Browse files

drm/xe: Use dma_fence_check_and_signal_locked() 



Xe is one of the few users utilizing the return code of
dma_fence_signal() to check whether a fence had already been signaled by
someone else.

To clean up and simplify the dma_fence API, the few kernel users relying
on that behavior shall be ported to an alternative function.

Replace dma_fence_signal_locked() with
dma_fence_check_and_signal_locked().

Acked-by: default avatarChristian König <christian.koenig@amd.com>
Acked-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Signed-off-by: default avatarPhilipp Stanner <phasta@kernel.org>
Link: https://patch.msgid.link/20251201105011.19386-6-phasta@kernel.org
parent 06bc18e0

drivers/gpu/drm/xe/xe_hw_fence.c

+1 −3
Original line number Diff line number Diff line
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) 
{

	struct xe_hw_fence *fence, *next;

	unsigned long flags;

	int err;

	bool tmp;



	if (XE_WARN_ON(!list_empty(&irq->pending))) {
@@ -93,9 +92,8 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) 
		spin_lock_irqsave(&irq->lock, flags);

		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {

			list_del_init(&fence->irq_link);

			err = dma_fence_signal_locked(&fence->dma);

			XE_WARN_ON(dma_fence_check_and_signal_locked(&fence->dma));

			dma_fence_put(&fence->dma);

			XE_WARN_ON(err);

		}

		spin_unlock_irqrestore(&irq->lock, flags);

		dma_fence_end_signalling(tmp);