Commit dc2ab23b authored Mar 17, 2022 by Alexander Gordeev Committed by Vasily Gorbik Mar 27, 2022

s390/smp: cleanup target CPU callback starting



Macro mem_assign_absolute() is used to initialize a target
CPU lowcore callback parameters. But despite the macro name
it writes to the absolute lowcore only if the target CPU is
offline. In case the CPU is online the macro does implicitly
write to the normal memory.

That behaviour is correct, but extremely subtle. Sacrifice
few program bits in favour of clarity and distinguish between
online vs offline CPUs and normal vs absolute lowcore pointer.

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

parent afacda5f

arch/s390/kernel/smp.c

+11 −4

Original line number	Diff line number	Diff line
		@@ -326,10 +326,17 @@ static void pcpu_delegate(struct pcpu *pcpu,
		/* Stop target cpu (if func returns this stops the current cpu). */
		pcpu_sigp_retry(pcpu, SIGP_STOP, 0);
		/* Restart func on the target cpu and stop the current cpu. */
		if (lc) {
		lc->restart_stack = stack;
		lc->restart_fn = (unsigned long)func;
		lc->restart_data = (unsigned long)data;
		lc->restart_source = source_cpu;
		} else {
		mem_assign_absolute(lc->restart_stack, stack);
		mem_assign_absolute(lc->restart_fn, (unsigned long)func);
		mem_assign_absolute(lc->restart_data, (unsigned long)data);
		mem_assign_absolute(lc->restart_source, source_cpu);
		}
		__bpon();
		asm volatile(
		"0: sigp 0,%0,%2 # sigp restart to target cpu\n"