Unverified Commit dc2d9842 authored by Shuicheng Lin's avatar Shuicheng Lin Committed by Rodrigo Vivi
Browse files

drm/xe/eustall: Fix drm_dev_put called before stream disable in close 



In xe_eu_stall_stream_close(), drm_dev_put() is called before the
stream is disabled and its resources are freed. If this drops the
last reference, the device structures could be freed while the
subsequent cleanup code still accesses them, leading to a
use-after-free.

Fix this by moving drm_dev_put() after all device accesses are
complete. This matches the ordering in xe_oa_release().

Fixes: 9a0b11d4 ("drm/xe/eustall: Add support to init, enable and disable EU stall sampling")
Cc: Harish Chegondi <harish.chegondi@intel.com>
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: default avatarShuicheng Lin <shuicheng.lin@intel.com>
Reviewed-by: default avatarHarish Chegondi <harish.chegondi@intel.com>
Link: https://patch.msgid.link/20260415225428.3399934-1-shuicheng.lin@intel.com


Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
(cherry picked from commit 35aff528f7297e949e5e19c9cd7fd748cf1cf21c)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent f3cc22d4

drivers/gpu/drm/xe/xe_eu_stall.c

+2 −2
Original line number Diff line number Diff line
@@ -869,14 +869,14 @@ static int xe_eu_stall_stream_close(struct inode *inode, struct file *file) 
	struct xe_eu_stall_data_stream *stream = file->private_data;

	struct xe_gt *gt = stream->gt;



	drm_dev_put(&gt->tile->xe->drm);



	mutex_lock(&gt->eu_stall->stream_lock);

	xe_eu_stall_disable_locked(stream);

	xe_eu_stall_data_buf_destroy(stream);

	xe_eu_stall_stream_free(stream);

	mutex_unlock(&gt->eu_stall->stream_lock);



	drm_dev_put(&gt->tile->xe->drm);



	return 0;

}