Commit dc534bdc authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI/pwrctrl: tc9563: Clean up whitespace 



Most of pci-pwrctrl-tc9563.c fits in 80 columns.  Wrap lines that are
gratuitously longer.  Whitespace changes only.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260115-pci-pwrctrl-rework-v5-4-9d26da3ce903@oss.qualcomm.com
parent 99ee5837

drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c

+42 −23
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ 
#define TC9563_POWER_CONTROL_OVREN	0x82b2c8



#define TC9563_GPIO_MASK		0xfffffff3

#define TC9563_GPIO_DEASSERT_BITS	0xc  /* Bits to clear for GPIO deassert */

#define TC9563_GPIO_DEASSERT_BITS	0xc  /* Clear to deassert GPIO */



#define TC9563_TX_MARGIN_MIN_UA		400000
@@ -69,7 +69,7 @@ 
 */

#define TC9563_OSC_STAB_DELAY_US	(10 * USEC_PER_MSEC)



#define TC9563_L0S_L1_DELAY_UNIT_NS	256  /* Each unit represents 256 nanoseconds */

#define TC9563_L0S_L1_DELAY_UNIT_NS	256  /* Each unit represents 256 ns */



struct tc9563_pwrctrl_reg_setting {

	unsigned int offset;
@@ -217,7 +217,8 @@ static int tc9563_pwrctrl_i2c_read(struct i2c_client *client, 
}



static int tc9563_pwrctrl_i2c_bulk_write(struct i2c_client *client,

					 const struct tc9563_pwrctrl_reg_setting *seq, int len)

				const struct tc9563_pwrctrl_reg_setting *seq,

				int len)

{

	int ret, i;
@@ -252,12 +253,13 @@ static int tc9563_pwrctrl_disable_port(struct tc9563_pwrctrl_ctx *ctx, 
	if (ret)

		return ret;



	return tc9563_pwrctrl_i2c_bulk_write(ctx->client,

					    common_pwroff_seq, ARRAY_SIZE(common_pwroff_seq));

	return tc9563_pwrctrl_i2c_bulk_write(ctx->client, common_pwroff_seq,

					     ARRAY_SIZE(common_pwroff_seq));

}



static int tc9563_pwrctrl_set_l0s_l1_entry_delay(struct tc9563_pwrctrl_ctx *ctx,

						 enum tc9563_pwrctrl_ports port, bool is_l1, u32 ns)

						 enum tc9563_pwrctrl_ports port,

						 bool is_l1, u32 ns)

{

	u32 rd_val, units;

	int ret;
@@ -269,24 +271,32 @@ static int tc9563_pwrctrl_set_l0s_l1_entry_delay(struct tc9563_pwrctrl_ctx *ctx, 
	units = ns / TC9563_L0S_L1_DELAY_UNIT_NS;



	if (port == TC9563_ETHERNET) {

		ret = tc9563_pwrctrl_i2c_read(ctx->client, TC9563_EMBEDDED_ETH_DELAY, &rd_val);

		ret = tc9563_pwrctrl_i2c_read(ctx->client,

					      TC9563_EMBEDDED_ETH_DELAY,

					      &rd_val);

		if (ret)

			return ret;



		if (is_l1)

			rd_val = u32_replace_bits(rd_val, units, TC9563_ETH_L1_DELAY_MASK);

			rd_val = u32_replace_bits(rd_val, units,

						  TC9563_ETH_L1_DELAY_MASK);

		else

			rd_val = u32_replace_bits(rd_val, units, TC9563_ETH_L0S_DELAY_MASK);

			rd_val = u32_replace_bits(rd_val, units,

						  TC9563_ETH_L0S_DELAY_MASK);



		return tc9563_pwrctrl_i2c_write(ctx->client, TC9563_EMBEDDED_ETH_DELAY, rd_val);

		return tc9563_pwrctrl_i2c_write(ctx->client,

						TC9563_EMBEDDED_ETH_DELAY,

						rd_val);

	}



	ret = tc9563_pwrctrl_i2c_write(ctx->client, TC9563_PORT_SELECT, BIT(port));

	ret = tc9563_pwrctrl_i2c_write(ctx->client, TC9563_PORT_SELECT,

				       BIT(port));

	if (ret)

		return ret;



	return tc9563_pwrctrl_i2c_write(ctx->client,

				       is_l1 ? TC9563_PORT_L1_DELAY : TC9563_PORT_L0S_DELAY, units);

			is_l1 ? TC9563_PORT_L1_DELAY : TC9563_PORT_L0S_DELAY,

			units);

}



static int tc9563_pwrctrl_set_tx_amplitude(struct tc9563_pwrctrl_ctx *ctx,
@@ -321,7 +331,8 @@ static int tc9563_pwrctrl_set_tx_amplitude(struct tc9563_pwrctrl_ctx *ctx, 
		{TC9563_TX_MARGIN, amp},

	};



	return tc9563_pwrctrl_i2c_bulk_write(ctx->client, tx_amp_seq, ARRAY_SIZE(tx_amp_seq));

	return tc9563_pwrctrl_i2c_bulk_write(ctx->client, tx_amp_seq,

					     ARRAY_SIZE(tx_amp_seq));

}



static int tc9563_pwrctrl_disable_dfe(struct tc9563_pwrctrl_ctx *ctx,
@@ -364,8 +375,8 @@ static int tc9563_pwrctrl_disable_dfe(struct tc9563_pwrctrl_ctx *ctx, 
		{TC9563_PHY_RATE_CHANGE_OVERRIDE, 0x0},

	};



	return tc9563_pwrctrl_i2c_bulk_write(ctx->client,

					    disable_dfe_seq, ARRAY_SIZE(disable_dfe_seq));

	return tc9563_pwrctrl_i2c_bulk_write(ctx->client, disable_dfe_seq,

					     ARRAY_SIZE(disable_dfe_seq));

}



static int tc9563_pwrctrl_set_nfts(struct tc9563_pwrctrl_ctx *ctx,
@@ -381,18 +392,22 @@ static int tc9563_pwrctrl_set_nfts(struct tc9563_pwrctrl_ctx *ctx, 
	if (!nfts[0])

		return 0;



	ret =  tc9563_pwrctrl_i2c_write(ctx->client, TC9563_PORT_SELECT, BIT(port));

	ret =  tc9563_pwrctrl_i2c_write(ctx->client, TC9563_PORT_SELECT,

					BIT(port));

	if (ret)

		return ret;



	return tc9563_pwrctrl_i2c_bulk_write(ctx->client, nfts_seq, ARRAY_SIZE(nfts_seq));

	return tc9563_pwrctrl_i2c_bulk_write(ctx->client, nfts_seq,

					     ARRAY_SIZE(nfts_seq));

}



static int tc9563_pwrctrl_assert_deassert_reset(struct tc9563_pwrctrl_ctx *ctx, bool deassert)

static int tc9563_pwrctrl_assert_deassert_reset(struct tc9563_pwrctrl_ctx *ctx,

						bool deassert)

{

	int ret, val;



	ret = tc9563_pwrctrl_i2c_write(ctx->client, TC9563_GPIO_CONFIG, TC9563_GPIO_MASK);

	ret = tc9563_pwrctrl_i2c_write(ctx->client, TC9563_GPIO_CONFIG,

				       TC9563_GPIO_MASK);

	if (ret)

		return ret;
@@ -401,7 +416,8 @@ static int tc9563_pwrctrl_assert_deassert_reset(struct tc9563_pwrctrl_ctx *ctx, 
	return tc9563_pwrctrl_i2c_write(ctx->client, TC9563_RESET_GPIO, val);

}



static int tc9563_pwrctrl_parse_device_dt(struct tc9563_pwrctrl_ctx *ctx, struct device_node *node,

static int tc9563_pwrctrl_parse_device_dt(struct tc9563_pwrctrl_ctx *ctx,

					  struct device_node *node,

					  enum tc9563_pwrctrl_ports port)

{

	struct tc9563_pwrctrl_cfg *cfg = &ctx->cfg[port];
@@ -540,7 +556,8 @@ static int tc9563_pwrctrl_probe(struct platform_device *pdev) 
	for (int i = 0; i < ARRAY_SIZE(tc9563_supply_names); i++)

		ctx->supplies[i].supply = tc9563_supply_names[i];



	ret = devm_regulator_bulk_get(dev, TC9563_PWRCTL_MAX_SUPPLY, ctx->supplies);

	ret = devm_regulator_bulk_get(dev, TC9563_PWRCTL_MAX_SUPPLY,

				      ctx->supplies);

	if (ret) {

		dev_err_probe(dev, ret, "failed to get supply regulator\n");

		goto remove_i2c;
@@ -563,7 +580,8 @@ static int tc9563_pwrctrl_probe(struct platform_device *pdev) 


	/*

	 * Downstream ports are always children of the upstream port.

	 * The first node represents DSP1, the second node represents DSP2, and so on.

	 * The first node represents DSP1, the second node represents DSP2,

	 * and so on.

	 */

	for_each_child_of_node_scoped(pdev->dev.of_node, child) {

		port++;
@@ -574,7 +592,8 @@ static int tc9563_pwrctrl_probe(struct platform_device *pdev) 
		if (port == TC9563_DSP3) {

			for_each_child_of_node_scoped(child, child1) {

				port++;

				ret = tc9563_pwrctrl_parse_device_dt(ctx, child1, port);

				ret = tc9563_pwrctrl_parse_device_dt(ctx,

								child1, port);

				if (ret)

					break;

			}