Commit dc5db350 authored by Haotian Zhang's avatar Haotian Zhang Committed by Bjorn Andersson
Browse files

soc: qcom: smem: fix hwspinlock resource leak in probe error paths 



The hwspinlock acquired via hwspin_lock_request_specific() is not
released on several error paths. This results in resource leakage
when probe fails.

Switch to devm_hwspin_lock_request_specific() to automatically
handle cleanup on probe failure. Remove the manual hwspin_lock_free()
in qcom_smem_remove() as devm handles it automatically.

Fixes: 20bb6c9d ("soc: qcom: smem: map only partitions used by local HOST")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251029022733.255-1-vulab@iscas.ac.cn


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent df8764c2

drivers/soc/qcom/smem.c

+1 −2
Original line number Diff line number Diff line
@@ -1190,7 +1190,7 @@ static int qcom_smem_probe(struct platform_device *pdev) 
		return dev_err_probe(&pdev->dev, hwlock_id,

				     "failed to retrieve hwlock\n");



	smem->hwlock = hwspin_lock_request_specific(hwlock_id);

	smem->hwlock = devm_hwspin_lock_request_specific(&pdev->dev, hwlock_id);

	if (!smem->hwlock)

		return -ENXIO;
@@ -1243,7 +1243,6 @@ static void qcom_smem_remove(struct platform_device *pdev) 
{

	platform_device_unregister(__smem->socinfo);



	hwspin_lock_free(__smem->hwlock);

	__smem = NULL;

}