Commit dc9a91d2 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Thierry Reding
Browse files

drm/tegra: Fix shift overflow in tegra_shared_plane_atomic_update 

Clang warns:

drivers/gpu/drm/tegra/hub.c:513:11: warning: shift count >= width of
type [-Wshift-count-overflow]
                base |= BIT(39);
                        ^~~~~~~

BIT is unsigned long, which is 32-bit on ARCH=arm, hence the overflow
warning. Switch to BIT_ULL, which is 64-bit and will not overflow.

Fixes: 7b6f8467 ("drm/tegra: Support sector layout on Tegra194")
Link: https://github.com/ClangBuiltLinux/linux/issues/1351


Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 5dea4275

drivers/gpu/drm/tegra/hub.c

+1 −1
Original line number Diff line number Diff line
@@ -510,7 +510,7 @@ static void tegra_shared_plane_atomic_update(struct drm_plane *plane, 
	 * dGPU sector layout.

	 */

	if (tegra_plane_state->tiling.sector_layout == TEGRA_BO_SECTOR_LAYOUT_GPU)

		base |= BIT(39);

		base |= BIT_ULL(39);

#endif



	tegra_plane_writel(p, tegra_plane_state->format, DC_WIN_COLOR_DEPTH);