Commit dcd4313f authored by Fredric Cover's avatar Fredric Cover Committed by Steve French
Browse files

smb: client: change allocation requirements in DUP_CTX_STR macro 



Currently, the macro DUP_CTX_STR allocates new_ctx->field using
GFP_ATOMIC. DUP_CTX_STR is only used in smb3_fs_context_dup(), which
is never called in an atomic context. Using GFP_ATOMIC puts unnecessary
pressure on emergency memory pools.

Change GFP_ATOMIC to GFP_KERNEL.

Signed-off-by: default avatarFredric Cover <fredric.cover.lkernel@gmail.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent d1ebfce2

fs/smb/client/fs_context.c

+1 −1
Original line number Diff line number Diff line
@@ -420,7 +420,7 @@ static int parse_symlink_flavor(struct fs_context *fc, char *value, 
#define DUP_CTX_STR(field)						\

do {									\

	if (ctx->field) {						\

		new_ctx->field = kstrdup(ctx->field, GFP_ATOMIC);	\

		new_ctx->field = kstrdup(ctx->field, GFP_KERNEL);	\

		if (new_ctx->field == NULL) {				\

			smb3_cleanup_fs_context_contents(new_ctx);	\

			return -ENOMEM;					\