Commit dcf6e7cf authored by Vasileios Amoiridis's avatar Vasileios Amoiridis Committed by Greg Kroah-Hartman
Browse files

uio: uio_pdrv_genirq: Make use of irq_get_trigger_type() 



Convert the following case:

	struct irq_data *irq_data = irq_get_irq_data(irq);

	if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
		...
	}

to the simpler:

	if (irq_get_trigger_type(irq) ... ) {
		...
	}

by using the irq_get_trigger_type() function.

Suggested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarVasileios Amoiridis <vassilisamir@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240912235925.54465-3-vassilisamir@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2d23bc3c

drivers/uio/uio_pdrv_genirq.c

+1 −4
Original line number Diff line number Diff line
@@ -173,8 +173,6 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev) 
	}



	if (uioinfo->irq) {

		struct irq_data *irq_data = irq_get_irq_data(uioinfo->irq);



		/*

		 * If a level interrupt, dont do lazy disable. Otherwise the

		 * irq will fire again since clearing of the actual cause, on
@@ -182,8 +180,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev) 
		 * irqd_is_level_type() isn't used since isn't valid until

		 * irq is configured.

		 */

		if (irq_data &&

		    irqd_get_trigger_type(irq_data) & IRQ_TYPE_LEVEL_MASK) {

		if (irq_get_trigger_type(uioinfo->irq) & IRQ_TYPE_LEVEL_MASK) {

			dev_dbg(&pdev->dev, "disable lazy unmask\n");

			irq_set_status_flags(uioinfo->irq, IRQ_DISABLE_UNLAZY);

		}