Commit dcf8b7e4 authored by Akhil R's avatar Akhil R Committed by Herbert Xu
Browse files

crypto: tegra - check return value for hash do_one_req 



Initialize and check the return value in hash *do_one_req() functions
and exit the function if there is an error. This fixes the
'uninitialized variable' warnings reported by testbots.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202412071747.flPux4oB-lkp@intel.com/


Fixes: 0880bb3b ("crypto: tegra - Add Tegra Security Engine driver")
Signed-off-by: default avatarAkhil R <akhilrajeev@nvidia.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 1e245948

drivers/crypto/tegra/tegra-se-aes.c

+8 −2
Original line number Diff line number Diff line
@@ -1602,18 +1602,24 @@ static int tegra_cmac_do_one_req(struct crypto_engine *engine, void *areq) 
	struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);

	struct tegra_cmac_ctx *ctx = crypto_ahash_ctx(tfm);

	struct tegra_se *se = ctx->se;

	int ret;

	int ret = 0;



	if (rctx->task & SHA_UPDATE) {

		ret = tegra_cmac_do_update(req);

		if (ret)

			goto out;



		rctx->task &= ~SHA_UPDATE;

	}



	if (rctx->task & SHA_FINAL) {

		ret = tegra_cmac_do_final(req);

		if (ret)

			goto out;



		rctx->task &= ~SHA_FINAL;

	}



out:

	crypto_finalize_hash_request(se->engine, req, ret);



	return 0;

drivers/crypto/tegra/tegra-se-hash.c

+7 −0
Original line number Diff line number Diff line
@@ -437,14 +437,21 @@ static int tegra_sha_do_one_req(struct crypto_engine *engine, void *areq) 


	if (rctx->task & SHA_UPDATE) {

		ret = tegra_sha_do_update(req);

		if (ret)

			goto out;



		rctx->task &= ~SHA_UPDATE;

	}



	if (rctx->task & SHA_FINAL) {

		ret = tegra_sha_do_final(req);

		if (ret)

			goto out;



		rctx->task &= ~SHA_FINAL;

	}



out:

	crypto_finalize_hash_request(se->engine, req, ret);



	return 0;