Commit dd34d9fe authored by Anthony Yznaga's avatar Anthony Yznaga Committed by Andrew Morton
Browse files

mm: fix unaccount of memory on vma_link() failure 

Fix insert_vm_struct() so that only accounted memory is unaccounted if
vma_link() fails.

Link: https://lkml.kernel.org/r/20230830004324.16101-1-anthony.yznaga@oracle.com


Fixes: d4af56c5 ("mm: start tracking VMAs with maple tree")
Signed-off-by: default avatarAnthony Yznaga <anthony.yznaga@oracle.com>
Reviewed-by: default avatarLiam R. Howlett <Liam.Howlett@oracle.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 954652b9

mm/mmap.c

+2 −1
Original line number Diff line number Diff line
@@ -3278,6 +3278,7 @@ int insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma) 
	}



	if (vma_link(mm, vma)) {

		if (vma->vm_flags & VM_ACCOUNT)

			vm_unacct_memory(charged);

		return -ENOMEM;

	}