Commit dd41b283 authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu
Browse files

crypto: mips/crc32 - fix the CRC32C implementation 



Commit ca459e5f ("crypto: mips/crc32 - Clean up useless assignment
operations") changed crc32c_mips_le_hw() to use the instructions that
use the "regular" CRC32 polynomial instead of the Castagnoli polynomial.
Therefore it can't be computing CRC32C values correctly anymore.

I haven't been successful in running a MIPS kernel in QEMU, but based on
code review this is the fix that is needed.

Fixes: ca459e5f ("crypto: mips/crc32 - Clean up useless assignment operations")
Cc: Guan Wentao <guanwentao@uniontech.com>
Cc: WangYuli <wangyuli@uniontech.com>
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Acked-by: default avatarWentao Guan <guanwentao@uniontech.com>
Acked-by: default avatarWangYuli <wangyuli@uniontech.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent cd843399

arch/mips/crypto/crc32-mips.c

+3 −3
Original line number Diff line number Diff line
@@ -123,20 +123,20 @@ static u32 crc32c_mips_le_hw(u32 crc_, const u8 *p, unsigned int len) 
		for (; len >= sizeof(u64); p += sizeof(u64), len -= sizeof(u64)) {

			u64 value = get_unaligned_le64(p);



			CRC32(crc, value, d);

			CRC32C(crc, value, d);

		}



		if (len & sizeof(u32)) {

			u32 value = get_unaligned_le32(p);



			CRC32(crc, value, w);

			CRC32C(crc, value, w);

			p += sizeof(u32);

		}

	} else {

		for (; len >= sizeof(u32); len -= sizeof(u32)) {

			u32 value = get_unaligned_le32(p);



			CRC32(crc, value, w);

			CRC32C(crc, value, w);

			p += sizeof(u32);

		}

	}