Commit dd5bdaf2 authored by Ingo Molnar's avatar Ingo Molnar
Browse files

sched/debug: Make CONFIG_SCHED_DEBUG functionality unconditional 



All the big Linux distros enable CONFIG_SCHED_DEBUG, because
the various features it provides help not just with kernel
development, but with system administration and user-space
software development as well.

Reflect this reality and enable this functionality
unconditionally.

Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Tested-by: default avatarShrikanth Hegde <sshegde@linux.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ben Segall <bsegall@google.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Valentin Schneider <vschneid@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/20250317104257.3496611-4-mingo@kernel.org
parent 57903f72

fs/proc/base.c

+0 −7
Original line number Diff line number Diff line
@@ -1489,7 +1489,6 @@ static const struct file_operations proc_fail_nth_operations = { 
#endif





#ifdef CONFIG_SCHED_DEBUG

/*

 * Print out various scheduling related per-task fields:

 */
@@ -1539,8 +1538,6 @@ static const struct file_operations proc_pid_sched_operations = { 
	.release	= single_release,

};



#endif



#ifdef CONFIG_SCHED_AUTOGROUP

/*

 * Print out autogroup related information:
@@ -3331,9 +3328,7 @@ static const struct pid_entry tgid_base_stuff[] = { 
	ONE("status",     S_IRUGO, proc_pid_status),

	ONE("personality", S_IRUSR, proc_pid_personality),

	ONE("limits",	  S_IRUGO, proc_pid_limits),

#ifdef CONFIG_SCHED_DEBUG

	REG("sched",      S_IRUGO|S_IWUSR, proc_pid_sched_operations),

#endif

#ifdef CONFIG_SCHED_AUTOGROUP

	REG("autogroup",  S_IRUGO|S_IWUSR, proc_pid_sched_autogroup_operations),

#endif
@@ -3682,9 +3677,7 @@ static const struct pid_entry tid_base_stuff[] = { 
	ONE("status",    S_IRUGO, proc_pid_status),

	ONE("personality", S_IRUSR, proc_pid_personality),

	ONE("limits",	 S_IRUGO, proc_pid_limits),

#ifdef CONFIG_SCHED_DEBUG

	REG("sched",     S_IRUGO|S_IWUSR, proc_pid_sched_operations),

#endif

	NOD("comm",      S_IFREG|S_IRUGO|S_IWUSR,

			 &proc_tid_comm_inode_operations,

			 &proc_pid_set_comm_operations, {}),

include/linux/energy_model.h

+0 −2
Original line number Diff line number Diff line
@@ -240,9 +240,7 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd, 
	struct em_perf_state *ps;

	int i;



#ifdef CONFIG_SCHED_DEBUG

	WARN_ONCE(!rcu_read_lock_held(), "EM: rcu read lock needed\n");

#endif



	if (!sum_util)

		return 0;

include/linux/sched/debug.h

+0 −2
Original line number Diff line number Diff line
@@ -35,12 +35,10 @@ extern void show_stack(struct task_struct *task, unsigned long *sp, 


extern void sched_show_task(struct task_struct *p);



#ifdef CONFIG_SCHED_DEBUG

struct seq_file;

extern void proc_sched_show_task(struct task_struct *p,

				 struct pid_namespace *ns, struct seq_file *m);

extern void proc_sched_set_task(struct task_struct *p);

#endif



/* Attach to any functions which should be ignored in wchan output. */

#define __sched		__section(".sched.text")

include/linux/sched/topology.h

+0 −4
Original line number Diff line number Diff line
@@ -25,16 +25,12 @@ enum { 
};

#undef SD_FLAG



#ifdef CONFIG_SCHED_DEBUG



struct sd_flag_debug {

	unsigned int meta_flags;

	char *name;

};

extern const struct sd_flag_debug sd_flag_debug[];



#endif



#ifdef CONFIG_SCHED_SMT

static inline int cpu_smt_flags(void)

{

include/trace/events/sched.h

+0 −2
Original line number Diff line number Diff line
@@ -193,9 +193,7 @@ static inline long __trace_sched_switch_state(bool preempt, 
{

	unsigned int state;



#ifdef CONFIG_SCHED_DEBUG

	BUG_ON(p != current);

#endif /* CONFIG_SCHED_DEBUG */



	/*

	 * Preemption ignores task state, therefore preempted tasks are always