Unverified Commit dd7cb142 authored by Christian Brauner's avatar Christian Brauner
Browse files

fs: relax permissions for listmount() 

It is sufficient to have capabilities in the owning user namespace of
the mount namespace to list all mounts regardless of whether they are
reachable or not.

Link: https://lore.kernel.org/r/8adc0d3f4f7495faacc6a7c63095961f7f1637c7.1719243756.git.josef@toxicpanda.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent d04bccd8

fs/namespace.c

+1 −1
Original line number Diff line number Diff line
@@ -5104,7 +5104,7 @@ static ssize_t do_listmount(u64 mnt_parent_id, u64 last_mnt_id, u64 *mnt_ids, 
	 * mounts to show users.

	 */

	if (!is_path_reachable(real_mount(orig.mnt), orig.dentry, &root) &&

	    !ns_capable_noaudit(&init_user_ns, CAP_SYS_ADMIN))

	    !ns_capable_noaudit(ns->user_ns, CAP_SYS_ADMIN))

		return -EPERM;



	ret = security_sb_statfs(orig.dentry);