Commit dd865789 authored by Jiri Olsa's avatar Jiri Olsa Committed by Andrii Nakryiko
Browse files

bpf: Count missed stats in trace_call_bpf 



Increase misses stats in case bpf array execution is skipped
because of recursion check in trace_call_bpf.

Adding bpf_prog_inc_misses_counters that increase misses
counts for all bpf programs in bpf_prog_array.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Tested-by: default avatarSong Liu <song@kernel.org>
Reviewed-by: default avatarSong Liu <song@kernel.org>
Link: https://lore.kernel.org/bpf/20230920213145.1941596-5-jolsa@kernel.org
parent 3acf8ace

include/linux/bpf.h

+16 −0
Original line number Diff line number Diff line
@@ -2922,6 +2922,22 @@ static inline int sock_map_bpf_prog_query(const union bpf_attr *attr, 
#endif /* CONFIG_BPF_SYSCALL */

#endif /* CONFIG_NET && CONFIG_BPF_SYSCALL */



static __always_inline void

bpf_prog_inc_misses_counters(const struct bpf_prog_array *array)

{

	const struct bpf_prog_array_item *item;

	struct bpf_prog *prog;



	if (unlikely(!array))

		return;



	item = &array->items[0];

	while ((prog = READ_ONCE(item->prog))) {

		bpf_prog_inc_misses_counter(prog);

		item++;

	}

}



#if defined(CONFIG_INET) && defined(CONFIG_BPF_SYSCALL)

void bpf_sk_reuseport_detach(struct sock *sk);

int bpf_fd_reuseport_array_lookup_elem(struct bpf_map *map, void *key,

kernel/trace/bpf_trace.c

+3 −0
Original line number Diff line number Diff line
@@ -117,6 +117,9 @@ unsigned int trace_call_bpf(struct trace_event_call *call, void *ctx) 
		 * and don't send kprobe event into ring-buffer,

		 * so return zero here

		 */

		rcu_read_lock();

		bpf_prog_inc_misses_counters(rcu_dereference(call->prog_array));

		rcu_read_unlock();

		ret = 0;

		goto out;

	}