Commit ddba1b6c authored by Honggyu Kim's avatar Honggyu Kim Committed by Andrew Morton
Browse files

samples/damon: fix damon sample mtier for start failure 

The damon_sample_mtier_start() can fail so we must reset the "enable"
parameter to "false" again for proper rollback.

In such cases, setting Y to "enable" then N triggers the similar crash
with mtier because damon sample start failed but the "enable" stays as Y.

Link: https://lkml.kernel.org/r/20250702000205.1921-4-honggyu.kim@sk.com


Fixes: 82a08bde ("samples/damon: implement a DAMON module for memory tiering")
Signed-off-by: default avatarHonggyu Kim <honggyu.kim@sk.com>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f1221c84

samples/damon/mtier.c

+6 −2
Original line number Diff line number Diff line
@@ -164,8 +164,12 @@ static int damon_sample_mtier_enable_store( 
	if (enable == enabled)

		return 0;



	if (enable)

		return damon_sample_mtier_start();

	if (enable) {

		err = damon_sample_mtier_start();

		if (err)

			enable = false;

		return err;

	}

	damon_sample_mtier_stop();

	return 0;

}