Commit ddcfa796 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpuidle: teo: Simplify handling of total events count 



Instead of computing the total events count from scratch every time,
decay it and add a PULSE value to it in teo_update().

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarChristian Loehle <christian.loehle@arm.com>
Tested-by: default avatarAboorva Devarajan <aboorvad@linux.ibm.com>
Tested-by: default avatarChristian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/9388883.CDJkKcVGEf@rjwysocki.net
parent 13ed5c4a

drivers/cpuidle/governors/teo.c

+1 −4
Original line number Diff line number Diff line
@@ -189,8 +189,6 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev) 
		}

	}



	cpu_data->total = 0;



	/*

	 * Decay the "hits" and "intercepts" metrics for all of the bins and

	 * find the bins that the sleep length and the measured idle duration
@@ -202,8 +200,6 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev) 
		bin->hits -= bin->hits >> DECAY_SHIFT;

		bin->intercepts -= bin->intercepts >> DECAY_SHIFT;



		cpu_data->total += bin->hits + bin->intercepts;



		target_residency_ns = drv->states[i].target_residency_ns;



		if (target_residency_ns <= cpu_data->sleep_length_ns) {
@@ -228,6 +224,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev) 
			cpu_data->tick_intercepts += PULSE;

	}



	cpu_data->total -= cpu_data->total >> DECAY_SHIFT;

	cpu_data->total += PULSE;

}