Commit ddd0a426 authored by Herbert Xu's avatar Herbert Xu
Browse files

crypto: scompress - Fix scratch allocation failure handling 



If the scratch allocation fails, all subsequent allocations will
silently succeed without actually allocating anything.  Fix this
by only incrementing users when the allocation succeeds.

Fixes: 6a8487a1 ("crypto: scompress - defer allocation of scratch buffer to first use")
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Acked-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 7e0969ba

crypto/scompress.c

+5 −1
Original line number Diff line number Diff line
@@ -159,8 +159,12 @@ static int crypto_scomp_init_tfm(struct crypto_tfm *tfm) 
		if (ret)

			goto unlock;

	}

	if (!scomp_scratch_users++)

	if (!scomp_scratch_users) {

		ret = crypto_scomp_alloc_scratches();

		if (ret)

			goto unlock;

		scomp_scratch_users++;

	}

unlock:

	mutex_unlock(&scomp_lock);