Commit dddbd233 authored by Peng Fan's avatar Peng Fan Committed by Jassi Brar
Browse files

mailbox: Not protect module_put with spin_lock_irqsave 



&chan->lock is not supposed to protect 'chan->mbox'.
And in __mbox_bind_client, try_module_get is also not protected
by &chan->lock. So move module_put out of the lock protected
region.

Signed-off-by: default avatarPeng Fan <peng.fan@nxp.com>
Signed-off-by: default avatarJassi Brar <jassisinghbrar@gmail.com>
parent 8da4988b

drivers/mailbox/mailbox.c

+1 −1
Original line number Diff line number Diff line
@@ -486,8 +486,8 @@ void mbox_free_channel(struct mbox_chan *chan) 
	if (chan->txdone_method == TXDONE_BY_ACK)

		chan->txdone_method = TXDONE_BY_POLL;



	module_put(chan->mbox->dev->driver->owner);

	spin_unlock_irqrestore(&chan->lock, flags);

	module_put(chan->mbox->dev->driver->owner);

}

EXPORT_SYMBOL_GPL(mbox_free_channel);