Commit de02deab authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

sit: use exit_batch_rtnl() method 



exit_batch_rtnl() is called while RTNL is held,
and devices to be unregistered can be queued in the dev_kill_list.

This saves one rtnl_lock()/rtnl_unlock() pair
and one unregister_netdevice_many() call.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarAntoine Tenart <atenart@kernel.org>
Link: https://lore.kernel.org/r/20240206144313.2050392-14-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7a99f3c1

net/ipv6/sit.c

+5 −8
Original line number Diff line number Diff line
@@ -1875,22 +1875,19 @@ static int __net_init sit_init_net(struct net *net) 
	return err;

}



static void __net_exit sit_exit_batch_net(struct list_head *net_list)

static void __net_exit sit_exit_batch_rtnl(struct list_head *net_list,

					   struct list_head *dev_to_kill)

{

	LIST_HEAD(list);

	struct net *net;



	rtnl_lock();

	ASSERT_RTNL();

	list_for_each_entry(net, net_list, exit_list)

		sit_destroy_tunnels(net, &list);



	unregister_netdevice_many(&list);

	rtnl_unlock();

		sit_destroy_tunnels(net, dev_to_kill);

}



static struct pernet_operations sit_net_ops = {

	.init = sit_init_net,

	.exit_batch = sit_exit_batch_net,

	.exit_batch_rtnl = sit_exit_batch_rtnl,

	.id   = &sit_net_id,

	.size = sizeof(struct sit_net),

};