Commit de090d1c authored by Nam Cao's avatar Nam Cao Committed by Gabriele Monaco
Browse files

rv: Fix wrong type cast in enabled_monitors_next() 



Argument 'p' of enabled_monitors_next() is not a pointer to struct
rv_monitor, it is actually a pointer to the list_head inside struct
rv_monitor. Therefore it is wrong to cast 'p' to struct rv_monitor *.

This wrong type cast has been there since the beginning. But it still
worked because the list_head was the first field in struct rv_monitor_def.
This is no longer true since commit 24cbfe18 ("rv: Merge struct
rv_monitor_def into struct rv_monitor") moved the list_head, and this wrong
type cast became a functional problem.

Properly use container_of() instead.

Fixes: 24cbfe18 ("rv: Merge struct rv_monitor_def into struct rv_monitor")
Signed-off-by: default avatarNam Cao <namcao@linutronix.de>
Reviewed-by: default avatarGabriele Monaco <gmonaco@redhat.com>
Link: https://lore.kernel.org/r/20250806120911.989365-1-namcao@linutronix.de


Signed-off-by: default avatarGabriele Monaco <gmonaco@redhat.com>
parent 03ee64b5

kernel/trace/rv/rv.c

+1 −1
Original line number Diff line number Diff line
@@ -495,7 +495,7 @@ static void *available_monitors_next(struct seq_file *m, void *p, loff_t *pos) 
 */

static void *enabled_monitors_next(struct seq_file *m, void *p, loff_t *pos)

{

	struct rv_monitor *mon = p;

	struct rv_monitor *mon = container_of(p, struct rv_monitor, list);



	(*pos)++;