Commit de291b59 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Dan Williams
Browse files

iomap: turn the byte variable in iomap_zero_iter into a ssize_t 



@bytes also holds the return value from iomap_write_end, which can
contain a negative error value.  As @bytes is always less than the page
size even the signed type can hold the entire possible range.

Fixes: c6f40468 ("fsdax: decouple zeroing from the iomap buffered I/O code")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20211208091203.2927754-1-hch@lst.de


Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent b80892ca

fs/iomap/buffered-io.c

+1 −1
Original line number Diff line number Diff line
@@ -883,7 +883,7 @@ static loff_t iomap_zero_iter(struct iomap_iter *iter, bool *did_zero) 


	do {

		unsigned offset = offset_in_page(pos);

		size_t bytes = min_t(u64, PAGE_SIZE - offset, length);

		ssize_t bytes = min_t(u64, PAGE_SIZE - offset, length);

		struct page *page;

		int status;