Unverified Commit de35b06b authored by Bard Liao's avatar Bard Liao Committed by Mark Brown
Browse files

ASoC: sdca: test adev before calling acpi_dev_for_each_child 



sdca_lookup_functions may be called by a Peripheral that is not listed
in the ACPI table. Testing adev is required to avoid kernel NULL pointer
dereference.

Fixes: 3a513da1 ("ASoC: SDCA: add initial module")
Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarLiam Girdwood <liam.r.girdwood@intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://patch.msgid.link/20241113064133.162501-1-yung-chuan.liao@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fb5e67c9

sound/soc/sdca/sdca_functions.c

+4 −0
Original line number Diff line number Diff line
@@ -165,6 +165,10 @@ void sdca_lookup_functions(struct sdw_slave *slave) 
	struct device *dev = &slave->dev;

	struct acpi_device *adev = to_acpi_device_node(dev->fwnode);



	if (!adev) {

		dev_info(dev, "No matching ACPI device found, ignoring peripheral\n");

		return;

	}

	acpi_dev_for_each_child(adev, find_sdca_function, &slave->sdca_data);

}

EXPORT_SYMBOL_NS(sdca_lookup_functions, SND_SOC_SDCA);