Commit de50a7e3 authored by Diederik de Haas's avatar Diederik de Haas Committed by Heiko Stuebner
Browse files

arm64: dts: rockchip: Remove hdmi's 2nd interrupt on rk3328 



The "synopsys,dw-hdmi.yaml" binding specifies that the interrupts
property of the hdmi node has 'maxItems: 1', so the hdmi node in
rk3328.dtsi having 2 is incorrect.

Paragraph 1.3 ("System Interrupt connection") of the RK3328 TRM v1.1
page 16 and 17 define the following hdmi related interrupts:
-  67 hdmi_intr
- 103 hdmi_intr_wakeup

The difference of 32 is due to a different base used in the TRM.

The RK3399 (which uses the same binding) has '23: hdmi_irq' and
'24: hdmi_wakeup_irq' according to its TRM (page 19).
The RK3568 (also same binding) has '76: hdmi_wakeup' and '77: hdmi'
according to page 17 of its TRM.
In both cases the non-wakeup IRQ was used, so use that too for rk3328.

Helped-by: default avatarHeiko Stuebner <heiko@sntech.de>
Fixes: 725e351c ("arm64: dts: rockchip: add rk3328 display nodes")
Signed-off-by: default avatarDiederik de Haas <didi.debian@cknow.org>
Link: https://lore.kernel.org/r/20241008113344.23957-3-didi.debian@cknow.org


Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent 875ea82c

arch/arm64/boot/dts/rockchip/rk3328.dtsi

+1 −2
Original line number Diff line number Diff line
@@ -754,8 +754,7 @@ hdmi: hdmi@ff3c0000 { 
		compatible = "rockchip,rk3328-dw-hdmi";

		reg = <0x0 0xff3c0000 0x0 0x20000>;

		reg-io-width = <4>;

		interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,

			     <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;

		interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;

		clocks = <&cru PCLK_HDMI>,

			 <&cru SCLK_HDMI_SFC>,

			 <&cru SCLK_RTC32K>;