Commit de70981f authored by Harshitha Ramamurthy's avatar Harshitha Ramamurthy Committed by Jakub Kicinski
Browse files

gve: unlink old napi when stopping a queue using queue API 



When a queue is stopped using the ndo queue API, before
destroying its page pool, the associated NAPI instance
needs to be unlinked to avoid warnings.

Handle this by calling page_pool_disable_direct_recycling()
when stopping a queue.

Cc: stable@vger.kernel.org
Fixes: ebdfae0d ("gve: adopt page pool for DQ RDA mode")
Reviewed-by: default avatarPraveen Kaligineedi <pkaligineedi@google.com>
Signed-off-by: default avatarHarshitha Ramamurthy <hramamurthy@google.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250226003526.1546854-1-hramamurthy@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 01c9c123

drivers/net/ethernet/google/gve/gve_rx_dqo.c

+2 −0
Original line number Diff line number Diff line
@@ -109,10 +109,12 @@ static void gve_rx_reset_ring_dqo(struct gve_priv *priv, int idx) 
void gve_rx_stop_ring_dqo(struct gve_priv *priv, int idx)

{

	int ntfy_idx = gve_rx_idx_to_ntfy(priv, idx);

	struct gve_rx_ring *rx = &priv->rx[idx];



	if (!gve_rx_was_added_to_block(priv, idx))

		return;



	page_pool_disable_direct_recycling(rx->dqo.page_pool);

	gve_remove_napi(priv, ntfy_idx);

	gve_rx_remove_from_block(priv, idx);

	gve_rx_reset_ring_dqo(priv, idx);