Commit de7aeb5d authored by Thorsten Blum's avatar Thorsten Blum Committed by Stephen Boyd
Browse files

clk: hisilicon: Remove unnecessary local variable 



The local u64 variable refdiv_val has the same value as the local u32
variable val and can be removed. Remove it and use val directly as the
divisor to also remove the following Coccinelle/coccicheck warning
reported by do_div.cocci:

  WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead

Use the preferred div_u64() function instead of the do_div() macro.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@toblux.com>
Link: https://lore.kernel.org/r/20240801103616.20430-1-thorsten.blum@toblux.com


Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent ec562c9a

drivers/clk/hisilicon/clk-hi3559a.c

+3 −4
Original line number Diff line number Diff line
@@ -407,7 +407,7 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw, 
		unsigned long parent_rate)

{

	struct hi3559av100_clk_pll *clk = to_pll_clk(hw);

	u64 frac_val, fbdiv_val, refdiv_val;

	u64 frac_val, fbdiv_val;

	u32 postdiv1_val, postdiv2_val;

	u32 val;

	u64 tmp, rate;
@@ -435,14 +435,13 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw, 
	val = readl_relaxed(clk->ctrl_reg2);

	val = val >> clk->refdiv_shift;

	val &= ((1 << clk->refdiv_width) - 1);

	refdiv_val = val;



	/* rate = 24000000 * (fbdiv + frac / (1<<24) ) / refdiv  */

	rate = 0;

	tmp = 24000000 * fbdiv_val + (24000000 * frac_val) / (1 << 24);

	rate += tmp;

	do_div(rate, refdiv_val);

	do_div(rate, postdiv1_val * postdiv2_val);

	rate = div_u64(rate, val);

	rate = div_u64(rate, postdiv1_val * postdiv2_val);



	return rate;

}