Commit de96f6a3 authored by Michel Alex's avatar Michel Alex Committed by Andrew Lunn
Browse files

net: phy: dp83822: Fix reset pin definitions 



This change fixes a rare issue where the PHY fails to detect a link
due to incorrect reset behavior.

The SW_RESET definition was incorrectly assigned to bit 14, which is the
Digital Restart bit according to the datasheet. This commit corrects
SW_RESET to bit 15 and assigns DIG_RESTART to bit 14 as per the
datasheet specifications.

The SW_RESET define is only used in the phy_reset function, which fully
re-initializes the PHY after the reset is performed. The change in the
bit definitions should not have any negative impact on the functionality
of the PHY.

v2:
- added Fixes tag
- improved commit message

Cc: stable@vger.kernel.org
Fixes: 5dc39fd5 ("net: phy: DP83822: Add ability to advertise Fiber connection")
Signed-off-by: default avatarAlex Michel <alex.michel@wiedemann-group.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Message-ID: <AS1P250MB0608A798661549BF83C4B43EA9462@AS1P250MB0608.EURP250.PROD.OUTLOOK.COM>
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
parent 9f86df0e

drivers/net/phy/dp83822.c

+2 −2
Original line number Diff line number Diff line
@@ -45,8 +45,8 @@ 
/* Control Register 2 bits */

#define DP83822_FX_ENABLE	BIT(14)



#define DP83822_HW_RESET	BIT(15)

#define DP83822_SW_RESET	BIT(14)

#define DP83822_SW_RESET	BIT(15)

#define DP83822_DIG_RESTART	BIT(14)



/* PHY STS bits */

#define DP83822_PHYSTS_DUPLEX			BIT(2)