Unverified Commit debc1a49 authored by Joanne Koong's avatar Joanne Koong Committed by Christian Brauner
Browse files

iomap: don't mark folio uptodate if read IO has bytes pending 



If a folio has ifs metadata attached to it and the folio is partially
read in through an async IO helper with the rest of it then being read
in through post-EOF zeroing or as inline data, and the helper
successfully finishes the read first, then post-EOF zeroing / reading
inline will mark the folio as uptodate in iomap_set_range_uptodate().

This is a problem because when the read completion path later calls
iomap_read_end(), it will call folio_end_read(), which sets the uptodate
bit using XOR semantics. Calling folio_end_read() on a folio that was
already marked uptodate clears the uptodate bit.

Fix this by not marking the folio as uptodate if the read IO has bytes
pending. The folio uptodate state will be set in the read completion
path through iomap_end_read() -> folio_end_read().

Reported-by: default avatarWei Gao <wegao@suse.com>
Suggested-by: default avatarSasha Levin <sashal@kernel.org>
Tested-by: default avatarWei Gao <wegao@suse.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Cc: stable@vger.kernel.org # v6.19
Link: https://lore.kernel.org/linux-fsdevel/aYbmy8JdgXwsGaPP@autotest-wegao.qe.prg2.suse.org/


Fixes: b2f35ac4 ("iomap: add caller-provided callbacks for read and readahead")
Signed-off-by: default avatarJoanne Koong <joannelkoong@gmail.com>
Link: https://patch.msgid.link/20260303233420.874231-2-joannelkoong@gmail.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 10047142

fs/iomap/buffered-io.c

+12 −3
Original line number Diff line number Diff line
@@ -80,18 +80,27 @@ static void iomap_set_range_uptodate(struct folio *folio, size_t off, 
{

	struct iomap_folio_state *ifs = folio->private;

	unsigned long flags;

	bool uptodate = true;

	bool mark_uptodate = true;



	if (folio_test_uptodate(folio))

		return;



	if (ifs) {

		spin_lock_irqsave(&ifs->state_lock, flags);

		uptodate = ifs_set_range_uptodate(folio, ifs, off, len);

		/*

		 * If a read with bytes pending is in progress, we must not call

		 * folio_mark_uptodate(). The read completion path

		 * (iomap_read_end()) will call folio_end_read(), which uses XOR

		 * semantics to set the uptodate bit. If we set it here, the XOR

		 * in folio_end_read() will clear it, leaving the folio not

		 * uptodate.

		 */

		mark_uptodate = ifs_set_range_uptodate(folio, ifs, off, len) &&

				!ifs->read_bytes_pending;

		spin_unlock_irqrestore(&ifs->state_lock, flags);

	}



	if (uptodate)

	if (mark_uptodate)

		folio_mark_uptodate(folio);

}