Commit dedab674 authored by Hongyu Xie's avatar Hongyu Xie Committed by Greg Kroah-Hartman
Browse files

usb: cdns3: remove redundant if branch 



cdns->role_sw->dev->driver_data gets set in routines showing below,
cdns_init
  sw_desc.driver_data = cdns;
  cdns->role_sw = usb_role_switch_register(dev, &sw_desc);
    dev_set_drvdata(&sw->dev, desc->driver_data);

In cdns_resume,
cdns->role = cdns_role_get(cdns->role_sw); //line redundant
  struct cdns *cdns = usb_role_switch_get_drvdata(sw);
    dev_get_drvdata(&sw->dev)
      return dev->driver_data
return cdns->role;

"line redundant" equals to,
	cdns->role = cdns->role;

So fix this if branch.

Signed-off-by: default avatarHongyu Xie <xiehongyu1@kylinos.cn>
Acked-by: default avatarPeter Chen <peter.chen@kernel.org>
Link: https://lore.kernel.org/r/20241231013641.23908-1-xiehongyu1@kylinos.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f097a36e

drivers/usb/cdns3/core.c

+1 −3
Original line number Diff line number Diff line
@@ -529,9 +529,7 @@ int cdns_resume(struct cdns *cdns) 
	int ret = 0;



	if (cdns_power_is_lost(cdns)) {

		if (cdns->role_sw) {

			cdns->role = cdns_role_get(cdns->role_sw);

		} else {

		if (!cdns->role_sw) {

			real_role = cdns_hw_role_state_machine(cdns);

			if (real_role != cdns->role) {

				ret = cdns_hw_role_switch(cdns);