Commit df180e65 authored by Nathan Lynch's avatar Nathan Lynch Committed by Vinod Koul
Browse files

dmaengine: Revert "dmaengine: dmatest: Fix dmatest waiting less when interrupted" 

Several issues with this change:

* The analysis is flawed and it's unclear what problem is being
  fixed. There is no difference between wait_event_freezable_timeout()
  and wait_event_timeout() with respect to device interrupts. And of
  course "the interrupt notifying the finish of an operation happens
  during wait_event_freezable_timeout()" -- that's how it's supposed
  to work.

* The link at the "Closes:" tag appears to be an unrelated
  use-after-free in idxd.

* It introduces a regression: dmatest threads are meant to be
  freezable and this change breaks that.

See discussion here:
https://lore.kernel.org/dmaengine/878qpa13fe.fsf@AUSNATLYNCH.amd.com/



Fixes: e87ca16e ("dmaengine: dmatest: Fix dmatest waiting less when interrupted")
Signed-off-by: default avatarNathan Lynch <nathan.lynch@amd.com>
Link: https://lore.kernel.org/r/20250403-dmaengine-dmatest-revert-waiting-less-v1-1-8227c5a3d7c8@amd.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 97994333

drivers/dma/dmatest.c

+3 −3
Original line number Diff line number Diff line
@@ -841,7 +841,7 @@ static int dmatest_func(void *data) 
		} else {

			dma_async_issue_pending(chan);



			wait_event_timeout(thread->done_wait,

			wait_event_freezable_timeout(thread->done_wait,

					done->done,

					msecs_to_jiffies(params->timeout));