Commit df485a4b authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: usb: scarlett2: Fix missing NULL check 

scarlett2_input_select_ctl_info() sets up the string arrays allocated
via kasprintf(), but it misses NULL checks, which may lead to NULL
dereference Oops.  Let's add the proper NULL check.

Fixes: 8eba063b ("ALSA: scarlett2: Simplify linked channel handling")
Link: https://patch.msgid.link/20250731053714.29414-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 5e0753df

sound/usb/mixer_scarlett2.c

+6 −1
Original line number Diff line number Diff line
@@ -3978,8 +3978,13 @@ static int scarlett2_input_select_ctl_info( 
		goto unlock;



	/* Loop through each input */

	for (i = 0; i < inputs; i++)

	for (i = 0; i < inputs; i++) {

		values[i] = kasprintf(GFP_KERNEL, "Input %d", i + 1);

		if (!values[i]) {

			err = -ENOMEM;

			goto unlock;

		}

	}



	err = snd_ctl_enum_info(uinfo, 1, i,

				(const char * const *)values);