Commit df621530 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jonathan Cameron
Browse files

iio: adc: ti-ads1298: prevent divide by zero in ads1298_set_samp_freq() 



The "val" variable comes from the user so we need to ensure that it's not
zero.  In fact, all negative values are invalid as well.  Add a check for
that.

Fixes: 00ef7708 ("iio: adc: ti-ads1298: Add driver")
Acked-by: default avatarMike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/c32c9087-86de-423b-8101-67b4a7f9d728@moroto.mountain


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent debabbb1

drivers/iio/adc/ti-ads1298.c

+2 −0
Original line number Diff line number Diff line
@@ -258,6 +258,8 @@ static int ads1298_set_samp_freq(struct ads1298_private *priv, int val) 
		rate = ADS1298_CLK_RATE_HZ;

	if (!rate)

		return -EINVAL;

	if (val <= 0)

		return -EINVAL;



	factor = (rate >> ADS1298_SHIFT_DR_HR) / val;

	if (factor >= BIT(ADS1298_SHIFT_DR_LP))