Commit df698f3d authored by Kuan-Wei Chiu's avatar Kuan-Wei Chiu Committed by Hans Verkuil
Browse files

media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity8() 



Refactor parity calculations to use the standard parity8() helper.
This change eliminates redundant implementations.

Co-developed-by: default avatarYu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: default avatarYu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: default avatarKuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 47e0452b

drivers/media/pci/cx18/cx18-av-vbi.c

+2 −10
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
 */





#include <linux/bitops.h>

#include "cx18-driver.h"



/*
@@ -56,15 +57,6 @@ struct vbi_anc_data { 
	/* u8 fill[]; Variable number of fill bytes */

};



static int odd_parity(u8 c)

{

	c ^= (c >> 4);

	c ^= (c >> 2);

	c ^= (c >> 1);



	return c & 1;

}



static int decode_vps(u8 *dst, u8 *p)

{

	static const u8 biphase_tbl[] = {
@@ -278,7 +270,7 @@ int cx18_av_decode_vbi_line(struct v4l2_subdev *sd, 
		break;

	case 6:

		sdid = V4L2_SLICED_CAPTION_525;

		err = !odd_parity(p[0]) || !odd_parity(p[1]);

		err = !parity8(p[0]) || !parity8(p[1]);

		break;

	case 9:

		sdid = V4L2_SLICED_VPS;