Unverified Commit df69e17c authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Krzysztof Wilczyński
Browse files

PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers 

Currently, dw_pcie_ep_init_registers() API is directly called by the glue
drivers requiring active refclk from host. But for the other drivers, it is
getting called implicitly by dw_pcie_ep_init(). This is due to the fact
that this API initializes DWC EP specific registers and that requires an
active refclk (either from host or generated locally by endpoint itsef).

But, this causes a discrepancy among the glue drivers. So to avoid this
confusion, let's call this API directly from all glue drivers irrespective
of refclk dependency. Only difference here is that the drivers requiring
refclk from host will call this API only after the refclk is received and
other drivers without refclk dependency will call this API right after
dw_pcie_ep_init().

With this change, the check for 'core_init_notifier' flag can now be
dropped from dw_pcie_ep_init() API. This will also allow us to remove the
'core_init_notifier' flag completely in the later commits.

Link: https://lore.kernel.org/linux-pci/20240327-pci-dbi-rework-v12-7-082625472414@linaro.org


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
Reviewed-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
parent 7d6e64c4

drivers/pci/controller/dwc/pci-dra7xx.c

+7 −0
Original line number Diff line number Diff line
@@ -467,6 +467,13 @@ static int dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx, 
		return ret;

	}



	ret = dw_pcie_ep_init_registers(ep);

	if (ret) {

		dev_err(dev, "Failed to initialize DWC endpoint registers\n");

		dw_pcie_ep_deinit(ep);

		return ret;

	}



	return 0;

}

drivers/pci/controller/dwc/pci-imx6.c

+8 −0
Original line number Diff line number Diff line
@@ -1123,6 +1123,14 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie, 
		dev_err(dev, "failed to initialize endpoint\n");

		return ret;

	}



	ret = dw_pcie_ep_init_registers(ep);

	if (ret) {

		dev_err(dev, "Failed to initialize DWC endpoint registers\n");

		dw_pcie_ep_deinit(ep);

		return ret;

	}



	/* Start LTSSM. */

	imx6_pcie_ltssm_enable(dev);

drivers/pci/controller/dwc/pci-keystone.c

+9 −0
Original line number Diff line number Diff line
@@ -1286,6 +1286,13 @@ static int ks_pcie_probe(struct platform_device *pdev) 
		ret = dw_pcie_ep_init(&pci->ep);

		if (ret < 0)

			goto err_get_sync;



		ret = dw_pcie_ep_init_registers(&pci->ep);

		if (ret) {

			dev_err(dev, "Failed to initialize DWC endpoint registers\n");

			goto err_ep_init;

		}



		break;

	default:

		dev_err(dev, "INVALID device type %d\n", mode);
@@ -1295,6 +1302,8 @@ static int ks_pcie_probe(struct platform_device *pdev) 


	return 0;



err_ep_init:

	dw_pcie_ep_deinit(&pci->ep);

err_get_sync:

	pm_runtime_put(dev);

	pm_runtime_disable(dev);

drivers/pci/controller/dwc/pci-layerscape-ep.c

+7 −0
Original line number Diff line number Diff line
@@ -279,6 +279,13 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) 
	if (ret)

		return ret;



	ret = dw_pcie_ep_init_registers(&pci->ep);

	if (ret) {

		dev_err(dev, "Failed to initialize DWC endpoint registers\n");

		dw_pcie_ep_deinit(&pci->ep);

		return ret;

	}



	return ls_pcie_ep_interrupt_init(pcie, pdev);

}

drivers/pci/controller/dwc/pcie-artpec6.c

+12 −1
Original line number Diff line number Diff line
@@ -441,7 +441,18 @@ static int artpec6_pcie_probe(struct platform_device *pdev) 


		pci->ep.ops = &pcie_ep_ops;



		return dw_pcie_ep_init(&pci->ep);

		ret = dw_pcie_ep_init(&pci->ep);

		if (ret)

			return ret;



		ret = dw_pcie_ep_init_registers(&pci->ep);

		if (ret) {

			dev_err(dev, "Failed to initialize DWC endpoint registers\n");

			dw_pcie_ep_deinit(&pci->ep);

			return ret;

		}



		break;

	default:

		dev_err(dev, "INVALID device type %d\n", artpec6_pcie->mode);

	}