Commit df8017e8 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: bcm: asp2: remove tx_lpi_enabled 



Phylib maintains a copy of tx_lpi_enabled, which will be used to
populate the member when phy_ethtool_get_eee(). Therefore, writing to
this member before phy_ethtool_get_eee() will have no effect. Remove
it. Also remove setting our copy of info->eee.tx_lpi_enabled which
becomes write-only.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Tested-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/E1tXk7w-000r4r-Pq@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 54033f55

drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c

+0 −6
Original line number Diff line number Diff line
@@ -364,14 +364,9 @@ void bcmasp_eee_enable_set(struct bcmasp_intf *intf, bool enable) 


static int bcmasp_get_eee(struct net_device *dev, struct ethtool_keee *e)

{

	struct bcmasp_intf *intf = netdev_priv(dev);

	struct ethtool_keee *p = &intf->eee;



	if (!dev->phydev)

		return -ENODEV;



	e->tx_lpi_enabled = p->tx_lpi_enabled;



	return phy_ethtool_get_eee(dev->phydev, e);

}
@@ -394,7 +389,6 @@ static int bcmasp_set_eee(struct net_device *dev, struct ethtool_keee *e) 
			return ret;

		}



		intf->eee.tx_lpi_enabled = e->tx_lpi_enabled;

		bcmasp_eee_enable_set(intf, true);

	}