Commit dfda8e9a authored by Boris Brezillon's avatar Boris Brezillon Committed by Steven Price
Browse files

drm/panthor: Fix the "done_fence is initialized" detection logic 



After commit 541c8f24 ("dma-buf: detach fence ops on signal v3"),
dma_fence::ops == NULL can't be used to check if the fence is initialized.
Use dma_fence_was_initialized() instead.

v2:
- Use dma_fence_was_initialized() instead of open-coding it

Cc: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Philipp Stanner <phasta@kernel.org>
Cc: Christian König <christian.koenig@amd.com>
Reported-by: default avatarSteven Price <steven.price@arm.com>
Reported-by: default avatarNicolas Frattaroli <nicolas.frattaroli@collabora.com>
Fixes: 541c8f24 ("dma-buf: detach fence ops on signal v3")
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Tested-by: default avatarNicolas Frattaroli <nicolas.frattaroli@collabora.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Reviewed-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Signed-off-by: default avatarSteven Price <steven.price@arm.com>
Link: https://patch.msgid.link/20260309124318.222902-1-boris.brezillon@collabora.com
parent 81e1035e

drivers/gpu/drm/panthor/panthor_sched.c

+1 −1
Original line number Diff line number Diff line
@@ -3915,7 +3915,7 @@ static void job_release(struct kref *ref) 
	if (job->base.s_fence)

		drm_sched_job_cleanup(&job->base);



	if (job->done_fence && job->done_fence->ops)

	if (dma_fence_was_initialized(job->done_fence))

		dma_fence_put(job->done_fence);

	else

		dma_fence_free(job->done_fence);