Commit dfe9707c authored Jul 21, 2025 by Srinivasan Shanmugam Committed by Alex Deucher Jul 28, 2025

drm/amd/display: Fix misuse of /** to /* in 'dce_i2c_hw.c'



Fix the comment style before cntl_stuck_hw_workaround() by replacing
'/**' with '/*' since it is not a kdoc comment.

Fixes the below with gcc W=1:
display/dc/dce/dce_i2c_hw.c:380: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* If we boot without an HDMI display, the I2C engine does not get
  initialized

Fixes: 04d57f44 ("drm/amd/display: Workaround for stuck I2C arbitrage")
Cc: Alvin Lee <alvin.lee2@amd.com>
Cc: Dominik Kaszewski <dominik.kaszewski@amd.com>
Cc: Ivan Lipski <ivan.lipski@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Tom Chung <chiahsuan.chung@amd.com>
Cc: Roman Li <roman.li@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 9c288305

drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -377,10 +377,16 @@ static bool setup_engine(
		}

		/**
		* cntl_stuck_hw_workaround - Workaround for I2C engine stuck state
		* @dce_i2c_hw: Pointer to dce_i2c_hw structure
		*
		* If we boot without an HDMI display, the I2C engine does not get initialized
		* correctly. One of its symptoms is that SW_USE_I2C does not get cleared after
		* acquire, so that after setting SW_DONE_USING_I2C on release, the engine gets
		* acquire. After setting SW_DONE_USING_I2C on release, the engine gets
		* immediately reacquired by SW, preventing DMUB from using it.
		*
		* This function checks the I2C arbitration status and applies a release
		* workaround if necessary.
		*/
		static void cntl_stuck_hw_workaround(struct dce_i2c_hw *dce_i2c_hw)
		{