Commit e000df9f authored by SeongJae Park's avatar SeongJae Park Committed by Andrew Morton
Browse files

mm/damon/sysfs: don't hold kdamond_lock in before_terminate() 

damon_sysfs_before_terminate() is a DAMON callback that is executed from
the kdamond's context.  Hence it is safe to access DAMON context internal
data.  But the function is unnecessarily holding kdamond_lock of the
context.  It is just unnecessary.  Remove the locking code.

Link: https://lkml.kernel.org/r/20250705175000.56259-6-sj@kernel.org


Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent d2b5be74

mm/damon/sysfs.c

+0 −2
Original line number Diff line number Diff line
@@ -1387,12 +1387,10 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) 
	if (!damon_target_has_pid(ctx))

		return;



	mutex_lock(&ctx->kdamond_lock);

	damon_for_each_target_safe(t, next, ctx) {

		put_pid(t->pid);

		damon_destroy_target(t);

	}

	mutex_unlock(&ctx->kdamond_lock);

}



/*