Commit e00f20ba authored Apr 02, 2024 by Ville Syrjälä

drm/i915: Remove DRM_MODE_FLAG_DBLSCAN checks from .mode_valid() hooks



We never set connector->doublescan_allowed, so the probe helper
already filters out all doublescan modes for us.

Sadly we still need to keep the explicit doublescan checks
in .compute_config as outlined in commit e4dd27aa
("drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI")

Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240402135148.23011-2-ville.syrjala@linux.intel.com

parent 318e8258

drivers/gpu/drm/i915/display/intel_crt.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -356,9 +356,6 @@ intel_crt_mode_valid(struct drm_connector *connector,
		if (status != MODE_OK)
		return status;

		if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

		if (mode->clock < 25000)
		return MODE_CLOCK_LOW;

drivers/gpu/drm/i915/display/intel_dp_mst.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1302,11 +1302,6 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
		if (*status != MODE_OK)
		return 0;

		if (mode->flags & DRM_MODE_FLAG_DBLSCAN) {
		*status = MODE_NO_DBLESCAN;
		return 0;
		}

		max_link_clock = intel_dp_max_link_rate(intel_dp);
		max_lanes = intel_dp_max_lane_count(intel_dp);

drivers/gpu/drm/i915/display/intel_dsi.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -69,9 +69,6 @@ enum drm_mode_status intel_dsi_mode_valid(struct drm_connector *connector,

		drm_dbg_kms(&dev_priv->drm, "\n");

		if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

		status = intel_panel_mode_valid(intel_connector, mode);
		if (status != MODE_OK)
		return status;

drivers/gpu/drm/i915/display/intel_dvo.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -231,9 +231,6 @@ intel_dvo_mode_valid(struct drm_connector *_connector,
		if (status != MODE_OK)
		return status;

		if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

		/* XXX: Validate clock range */

		if (fixed_mode) {

drivers/gpu/drm/i915/display/intel_lvds.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -399,9 +399,6 @@ intel_lvds_mode_valid(struct drm_connector *_connector,
		if (status != MODE_OK)
		return status;

		if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

		status = intel_panel_mode_valid(connector, mode);
		if (status != MODE_OK)
		return status;