Commit e0344f95 authored by Siddarth G's avatar Siddarth G Committed by Steven Rostedt (Google)
Browse files

tracing: Replace strncpy with memcpy for fixed-length substring copy 

checkpatch.pl reports the following warning:
WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy
(see: https://github.com/KSPP/linux/issues/90)

In synth_field_string_size(), replace strncpy() with memcpy() to copy 'len'
characters from 'start' to 'buf'. The code manually adds a NUL terminator
after the copy, making memcpy safe here.

Link: https://lore.kernel.org/20250325181232.38284-1-siddarthsgml@gmail.com


Signed-off-by: default avatarSiddarth G <siddarthsgml@gmail.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 4d38328e

kernel/trace/trace_events_synth.c

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ static int synth_field_string_size(char *type) 
	if (len == 0)

		return 0; /* variable-length string */



	strncpy(buf, start, len);

	memcpy(buf, start, len);

	buf[len] = '\0';



	err = kstrtouint(buf, 0, &size);