Commit e0665df8 authored by Markus Elfring's avatar Markus Elfring Committed by Paolo Abeni
Browse files

net: ti: icssg-prueth: Omit a variable reassignment in prueth_netdev_init() 



An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete two redundant variable reassignments.

The source code was transformed by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/71f7daa3-d4f4-4753-aae8-67040fc8297d@web.de


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent d550d63d

drivers/net/ethernet/ti/icssg/icssg_prueth.c

+1 −2
Original line number Diff line number Diff line
@@ -1250,8 +1250,7 @@ static int prueth_netdev_init(struct prueth *prueth, 
	} else if (of_phy_is_fixed_link(eth_node)) {

		ret = of_phy_register_fixed_link(eth_node);

		if (ret) {

			ret = dev_err_probe(prueth->dev, ret,

					    "failed to register fixed-link phy\n");

			dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n");

			goto free;

		}

drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c

+1 −2
Original line number Diff line number Diff line
@@ -818,8 +818,7 @@ static int prueth_netdev_init(struct prueth *prueth, 
	} else if (of_phy_is_fixed_link(eth_node)) {

		ret = of_phy_register_fixed_link(eth_node);

		if (ret) {

			ret = dev_err_probe(prueth->dev, ret,

					    "failed to register fixed-link phy\n");

			dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n");

			goto free;

		}