Commit e07fec47 authored by Sandeep Dhavale's avatar Sandeep Dhavale Committed by Greg Kroah-Hartman
Browse files

usb: gadgetfs: Fix ep_read_iter to handle ITER_UBUF 



iov_iter for ep_read_iter can be ITER_UBUF with io_uring.
In that case dup_iter() does not have to allocate iov and it can
return NULL. Fix the assumption by checking for iter_is_ubuf()
other wise ep_read_iter can treat this as failure and return -ENOMEM.

Fixes: 1e23db45 ("io_uring: use iter_ubuf for single range imports")
Signed-off-by: default avatarSandeep Dhavale <dhavale@google.com>
Acked-by: default avatarJens Axboe <axboe@kernel.dk>
Link: https://lore.kernel.org/r/20230401060509.3608259-3-dhavale@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d356b3cd

drivers/usb/gadget/legacy/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -614,7 +614,7 @@ ep_read_iter(struct kiocb *iocb, struct iov_iter *to) 
		if (!priv)

			goto fail;

		priv->to_free = dup_iter(&priv->to, to, GFP_KERNEL);

		if (!priv->to_free) {

		if (!iter_is_ubuf(&priv->to) && !priv->to_free) {

			kfree(priv);

			goto fail;

		}